fix(react-router): preserve sourcemaps.disable override#20042
Open
fix(react-router): preserve sourcemaps.disable override#20042
Conversation
isaacs
pushed a commit
that referenced
this pull request
Mar 30, 2026
Ensure unstable vite plugin options don't overwrite sourcemaps.disable=true and update test expectations accordingly. Co-Authored-By: gpt-5.3-codex-high <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Nuxt
Other
Bug Fixes 🐛Ci
Node
React Router
Other
Documentation 📚
Internal Changes 🔧Core
Deps
Deps Dev
Other
🤖 This preview updates automatically when you update the PR. |
isaacs
force-pushed
the
cursor/sourcemaps-disable-overwrite-bug-311c
branch
from
5d78fc8 to
838a8e7
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
pushed a commit
that referenced
this pull request
Mar 30, 2026
Ensure unstable vite plugin options don't overwrite sourcemaps.disable=true and update test expectations accordingly. Co-Authored-By: gpt-5.3-codex-high <noreply@anthropic.com>
isaacs
force-pushed
the
cursor/sourcemaps-disable-overwrite-bug-311c
branch
from
838a8e7 to
a4d7eb2
Compare
Contributor
size-limit report 📦
|
isaacs
pushed a commit
that referenced
this pull request
Mar 30, 2026
Ensure unstable vite plugin options don't overwrite sourcemaps.disable=true and update test expectations accordingly. Co-Authored-By: gpt-5.3-codex-high <noreply@anthropic.com>
isaacs
force-pushed
the
cursor/sourcemaps-disable-overwrite-bug-311c
branch
from
a4d7eb2 to
ce47a95
Compare
isaacs
pushed a commit
that referenced
this pull request
Mar 30, 2026
Ensure unstable vite plugin options don't overwrite sourcemaps.disable=true and update test expectations accordingly. Co-Authored-By: gpt-5.3-codex-high <noreply@anthropic.com>
isaacs
force-pushed
the
cursor/sourcemaps-disable-overwrite-bug-311c
branch
from
ce47a95 to
caedbb6
Compare
Ensure unstable vite plugin options don't overwrite sourcemaps.disable=true and update test expectations accordingly. Co-Authored-By: gpt-5.3-codex-high <noreply@anthropic.com>
isaacs
force-pushed
the
cursor/sourcemaps-disable-overwrite-bug-311c
branch
from
caedbb6 to
1d54dd8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| ...unstable_sentryVitePluginOptions?._metaOptions, | ||
| }, | ||
| reactComponentAnnotation: { | ||
| ...unstable_sentryVitePluginOptions?.reactComponentAnnotation, |
There was a problem hiding this comment.
Unstable reactComponentAnnotation values always overridden by undefined
Low Severity
The reactComponentAnnotation section spreads unstable_sentryVitePluginOptions?.reactComponentAnnotation first, but then enabled: reactComponentAnnotation?.enabled ?? undefined explicitly sets enabled to undefined when the user doesn't provide it, overriding any unstable fallback value. The ?? undefined is a no-op. This is inconsistent with the release pattern, which uses ...release and naturally preserves unstable values when the main option isn't provided. Using ...reactComponentAnnotation instead of the explicit property assignments would be consistent.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure unstable vite plugin options don't overwrite sourcemaps.disable=true and update test expectations accordingly.
Before submitting a pull request, please take a look at our
Small issue found by cursor in #19890 right before it got merged.